Add video block show metadata option#1696
Open
geichelberger wants to merge 4 commits intoelan-ev:mainfrom
Open
Add video block show metadata option#1696geichelberger wants to merge 4 commits intoelan-ev:mainfrom
geichelberger wants to merge 4 commits intoelan-ev:mainfrom
Conversation
This adds the show metadata option for the video block to show supplemental metadata for embedded videos.
owi92
requested changes
Mar 30, 2026
Member
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Thank you for the PR, and sorry for the delay in reviewing.
I think this is a reasonable and useful feature to add. I have a few comments on the frontend code, but otherwise this looks good to me.
owi92
approved these changes
Mar 31, 2026
Member
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Thanks again. I think Lukas wanted to take a look at this before we merge it, but he's on vacation right now. We'll probably get it in next week.
Member
|
@geichelberger Edit: That's not correct, sorry. I think the test is just broken or something. No action needed from your side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to display supplemental metadata for embedded videos within the video block.
Without description:
