Skip to content

Conversation

ajayspinny
Copy link

@ajayspinny ajayspinny commented Feb 28, 2025

What does this pull request do?

The current grpc instrumentation expects host value with a port that may not always be true. In our project we use internal host with out a port value

target = kwargs.get("target") or args[0]
if ":" in target:
    host, port = target.split(":")
    try:
        port = int(port)
    except ValueError:
        port = None
else:
    host, port = None, None

This results in span showing None value and we are not able to track the external host value. All grpc hosts are clubbed together under https://None value

The proposal is to keep the target value as is in case there is no ':' in the host and keep the port as None

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
57b8080

Please, read and sign the above mentioned agreement if you want to contribute to this project

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Feb 28, 2025
@ajayspinny ajayspinny closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants