Skip to content

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 9, 2025

What

  1. The workflow will create the docker images on demand and store in the GitHub container registry
  2. Packages are now accessible at https://github.com/elastic/apm-agent-python/pkgs/container/apm-agent-python%2Fapm-agent-python-testing
  3. Use the new container images
  4. Less verbose docker pull output

Tests

See https://github.com/elastic/apm-agent-python/actions/runs/14772579891/job/41475033985

@v1v v1v self-assigned this Apr 9, 2025
@v1v v1v requested review from a team April 9, 2025 13:14
@v1v v1v marked this pull request as ready for review April 9, 2025 13:14
xrmx
xrmx previously approved these changes Apr 9, 2025
xrmx
xrmx previously approved these changes Apr 9, 2025
@v1v
Copy link
Member Author

v1v commented Apr 9, 2025

#15 5.405 Downloading six-1.17.0-py2.py3-none-any.whl (11 kB)
#15 5.435 Building wheels for collected packages: pytest-localserver
#15 5.436   Building wheel for pytest-localserver (setup.py): started
#15 5.623   Building wheel for pytest-localserver (setup.py): finished with status 'error'
#15 5.628   error: subprocess-exited-with-error
#15 5.628   
#15 5.628   × python setup.py bdist_wheel did not run successfully.
#15 5.628   │ exit code: 1
#15 5.628   ╰─> [8 lines of output]
#15 5.628       /usr/local/lib/python3.10/site-packages/setuptools/dist.py:771: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
#15 5.628         warnings.warn(
#15 5.628       usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
#15 5.628          or: setup.py --help [cmd1 cmd2 ...]
#15 5.628          or: setup.py --help-commands
#15 5.628          or: setup.py cmd --help
#15 5.628       
#15 5.628       error: invalid command 'bdist_wheel'
#15 5.628       [end of output]
#15 5.628   
#15 5.628   note: This error originates from a subprocess, and is likely not a problem with pip.
#15 5.628   ERROR: Failed building wheel for pytest-localserver
#15 5.629   Running setup.py clean for pytest-localserver
#15 5.822 Failed to build pytest-localserver

Known issue, I thin something is wrong with wheel, we have seen that in some other projects, see pypa/wheel#662 (comment)

@v1v v1v enabled auto-merge (squash) April 9, 2025 13:54
@xrmx
Copy link
Member

xrmx commented Apr 9, 2025

#15 5.405 Downloading six-1.17.0-py2.py3-none-any.whl (11 kB)
#15 5.435 Building wheels for collected packages: pytest-localserver
#15 5.436   Building wheel for pytest-localserver (setup.py): started
#15 5.623   Building wheel for pytest-localserver (setup.py): finished with status 'error'
#15 5.628   error: subprocess-exited-with-error
#15 5.628   
#15 5.628   × python setup.py bdist_wheel did not run successfully.
#15 5.628   │ exit code: 1
#15 5.628   ╰─> [8 lines of output]
#15 5.628       /usr/local/lib/python3.10/site-packages/setuptools/dist.py:771: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
#15 5.628         warnings.warn(
#15 5.628       usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
#15 5.628          or: setup.py --help [cmd1 cmd2 ...]
#15 5.628          or: setup.py --help-commands
#15 5.628          or: setup.py cmd --help
#15 5.628       
#15 5.628       error: invalid command 'bdist_wheel'
#15 5.628       [end of output]
#15 5.628   
#15 5.628   note: This error originates from a subprocess, and is likely not a problem with pip.
#15 5.628   ERROR: Failed building wheel for pytest-localserver
#15 5.629   Running setup.py clean for pytest-localserver
#15 5.822 Failed to build pytest-localserver

Known issue, I thin something is wrong with wheel, we have seen that in some other projects, see pypa/wheel#662 (comment)

This was a setuptools version that removed support for description-file after years of deprecations but a new one has been released with the removal reverted. Let me check if I can bump pytest-localserver to something newer than 3 years old.

@xrmx
Copy link
Member

xrmx commented Apr 10, 2025

Bumped pytest-localserver to a version that should have proper metadata.

@xrmx
Copy link
Member

xrmx commented Apr 10, 2025

@v1v silly quesiton: will I be able to run this on a branch? I need the image built from the branch adding 3.13 to the matrix in order to have tests for that PR pass.

@v1v
Copy link
Member Author

v1v commented Apr 10, 2025

@v1v silly quesiton: will I be able to run this on a branch? I need the image built from the branch adding 3.13 to the matrix in order to have tests for that PR pass.

Yes, workflow_dispatch: ~ is the way, then, once this PR is merged, you will be able to run on any branch.


Let me create a test branch with these changes to validate recent changes

https://github.com/elastic/apm-agent-python/actions/runs/14377179793/job/40312254554 is now running

@xrmx xrmx force-pushed the feature/workflow-build-images branch from d3a5a25 to a815a93 Compare April 29, 2025 13:15
@v1v v1v marked this pull request as draft May 1, 2025 08:22
auto-merge was automatically disabled May 1, 2025 08:22

Pull request was converted to draft

@v1v v1v changed the title github-actions: build images github-actions: use GitHub container registry May 1, 2025
@v1v v1v marked this pull request as ready for review May 1, 2025 09:03
@v1v v1v enabled auto-merge (squash) May 1, 2025 11:05
@v1v v1v merged commit abe4bb3 into main May 5, 2025
120 checks passed
@v1v v1v deleted the feature/workflow-build-images branch May 5, 2025 12:30
@xrmx
Copy link
Member

xrmx commented May 5, 2025

Thanks a lot @v1v !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants