Skip to content

Remove usage of deprecated pkg_resource in favor of importlib.metadata #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

Remove usage of deprecated pkg_resource in favor of importlib.metadata #2349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9336b5
Remove usage of deprecated pkg_resource in favor of importlib.metadata
xrmx Jul 9, 2025
d260fad
Add test for VERSION not being unknown
xrmx Jul 11, 2025
8e04e3c
Skip unknown version on Python 3.8 as it behaves differently
xrmx Jul 11, 2025
9643831
Keep using pkg_resources as fallback for getting version
xrmx Jul 11, 2025
55b9f16
No test then
xrmx Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions elasticapm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
import sys
import importlib.metadata

from elasticapm.base import Client, get_client # noqa: F401
from elasticapm.conf import setup_logging # noqa: F401
Expand All @@ -54,10 +55,7 @@
_activation_method = None

try:
try:
VERSION = __import__("importlib.metadata").metadata.version("elastic-apm")
except ImportError:
VERSION = __import__("pkg_resources").get_distribution("elastic-apm").version
VERSION = importlib.metadata.version("elastic-apm")
except Exception:
VERSION = "unknown"

Expand Down
3 changes: 0 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,8 @@
import codecs
import os

import pkg_resources
from setuptools import setup

pkg_resources.require("setuptools>=39.2")


def get_version():
"""
Expand Down
4 changes: 4 additions & 0 deletions tests/client/client_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,3 +558,7 @@ def test_user_agent(elasticapm_client, expected):

def test_label_without_client():
elasticapm.label(foo="foo")


def test_version_is_not_unknown():
assert elasticapm.VERSION != "unknown"
Loading