Skip to content

Revert old python support removal #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2025
Merged

Revert old python support removal #2385

merged 4 commits into from
Aug 11, 2025

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Aug 4, 2025

What does this pull request do?

This reverts 8ac1781 and 76cf5c8. The plan is to release a minor version first so we cannot break backwards compatibility.

Related issues

Refs #2029

@xrmx xrmx requested review from a team as code owners August 4, 2025 10:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025 •
edited
Loading

🔍 Preview links for changed docs

@trentm
Copy link
Member

trentm commented Aug 6, 2025

Er, though tests for Python 3.6 are failling.

@xrmx
Revert "Use unittest.mock instead of the mock backport package (elast…
598d191 
…ic#2370)"

This reverts commit 7241b27.

[xrmx: keep the azurestorage marker addition]
@xrmx xrmx force-pushed the revert-old-python-support-removal branch from 113897a to 598d191 Compare August 11, 2025 09:26
@xrmx
Copy link
Member Author

xrmx commented Aug 11, 2025

Ok so mock backport module was there for a reason, with 3.6 and 3.7 stdlib unittest mock we were not able to properly assert kwargs on a Mock instance.

@xrmx
Copy link
Member Author

xrmx commented Aug 11, 2025

Mongodb tests fixed here #2391

@xrmx xrmx enabled auto-merge (squash) August 11, 2025 15:07
@xrmx xrmx merged commit 8446aa1 into elastic:main Aug 11, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trentm trentm trentm approved these changes

@hegerchr hegerchr hegerchr approved these changes

Assignees

No one assigned

Labels

agent-python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrmx @trentm @hegerchr