chore: upgrade lerna and remove remaining saucelabs code #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
david-luna
commented
Oct 20, 2025
| ARG NODEJS_VERSION | ||
|
|
||
| # Install node | ||
| RUN apt-get update && apt-get install -y ca-certificates curl gnupg && \ |
There was a problem hiding this comment.
note for reviewer: just formatting
david-luna
commented
Oct 20, 2025
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| # Temporary fix for "ValueError: invalid mode: 'rU' while trying to load binding.gyp" |
There was a problem hiding this comment.
note for reviewer: fix was for saucelabs tests which is gone
david-luna
commented
Oct 20, 2025
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
There was a problem hiding this comment.
note for reviewer: fix was for saucelabs tests which is gone
david-luna
changed the title
david-luna
changed the title
trentm
previously approved these changes
Oct 21, 2025
v1v
previously approved these changes
Oct 21, 2025
Co-authored-by: Trent Mick <[email protected]>
v1v
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #1644