-
Notifications
You must be signed in to change notification settings - Fork 147
chore: upgrde lerna and remove unused saucelabs code #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
703ca71
36fb377
59e6dd5
775d10c
41b398b
8746dbf
9b8595c
d138112
4c59e15
ae6543a
79c36e0
9b700ae
64af869
096653b
00efd76
50b0427
3e51247
794f273
63e0e65
d1bee3a
091dd82
20827bd
a3ccf3c
a61e0f7
cce743e
051607f
c059413
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ jobs: | |
strategy: | ||
matrix: | ||
stack-version: | ||
- '8.0.0-SNAPSHOT' | ||
- '8.2.0-SNAPSHOT' | ||
- '8.19.5' | ||
scope: | ||
- '@elastic/apm-rum' | ||
|
@@ -75,6 +75,7 @@ jobs: | |
- '@elastic/apm-rum-vue' | ||
steps: | ||
- uses: actions/checkout@v5 | ||
|
||
- name: Run puppeteer tests | ||
uses: ./.github/workflows/run-test | ||
with: | ||
|
@@ -87,14 +88,6 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v5 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note for reviewer: fix was for saucelabs tests which is gone |
||
# Temporary fix for "ValueError: invalid mode: 'rU' while trying to load binding.gyp" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note for reviewer: fix was for saucelabs tests which is gone |
||
# See https://github.com/nodejs/node-gyp/issues/2219 | ||
# This can be removed when "node-gyp" is updated | ||
- name: Set up Python 3.10 | ||
uses: actions/setup-python@v6 | ||
with: | ||
python-version: '3.10' | ||
|
||
- uses: actions/setup-node@v5 | ||
with: | ||
node-version-file: '.nvmrc' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ on: | |
workflow_run: | ||
workflows: | ||
- ci | ||
- ci-saucelabs | ||
types: | ||
- completed | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
18 | ||
20 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
18 | ||
20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: just formatting