fix(release): set the dependencies versions when publishign in dry-run mode #1688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last release related PR #1683 had one thing missing which was pointed out by @vigneshshanmugam in #1683 (comment)
After several tests we can say:
dry-runmode is affected and packages are published with afile:..reference in their dependenciesproductionmode is not affected since we are still usinglernafor this modeThis PR is fixing the issue for the dry run mode which publish in a local
verdaccioregistry. I verified with the following steps:docker run -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccioin one terminalDRY_RUN=true npm run ci:releasein another terminal. Like the release workflow is doingpackage.jsonfile in a local folder then runnpm i @elastic/apm-rum-angular --registry=http://localhost:4873@elastic/apm-rum-core&@elastic/apm-rumdependencies are installed correctly@elastic/apm-rum-angularhas the right version number for them