accumulator: add error handling for writing to buffer #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors were ignored so far when trying to write to the buffer.
florianl
commented
Oct 21, 2024
rockdaboot
reviewed
Oct 21, 2024
rockdaboot
reviewed
Oct 21, 2024
florianl
commented
Oct 21, 2024
florianl
commented
Oct 21, 2024
florianl
commented
Oct 21, 2024
rockdaboot
approved these changes
Oct 21, 2024
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
LGTM
(nit: merge err != nil into previous line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors were ignored so far when trying to write to the buffer.