Update golang.org/x/crypto to v0.31.0 #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
previously approved these changes
Dec 18, 2024
tools/go.mod
Outdated
| toolchain go1.23.1 | ||
| go 1.23 | ||
|
|
||
| toolchain go1.23.4 |
There was a problem hiding this comment.
we can probably drop the toolchain
There was a problem hiding this comment.
What is your GOTOOLCHAIN setting to avoid go mod tidy to add the toolchain entry?
There was a problem hiding this comment.
there's no way to do that with go mod tidy unfortunately. I usually run go mod tidy -go=x to see if some deps is requesting a higher go version. If everything is good go get toolchain@none should drop the toolchain.
This should probably be fixed upstream :(
florianl
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/elastic/apm-aws-lambda/security/dependabot/40
The code is not directly using the vulnerable function, but better be on the safe side and update.