iserver-test: Overhaul upgrade config #19020
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericywl
added
the
backport-skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
carsonip
approved these changes
Oct 10, 2025
| to, err := parseLazyRolloverExceptionVersionRange(e.To) | ||
| if err != nil { | ||
| return upgradeTestConfig{}, fmt.Errorf( | ||
| "failed to parse lazy-rollover-exception version '%s': %w", e.From, err) |
There was a problem hiding this comment.
Suggested change
| "failed to parse lazy-rollover-exception version '%s': %w", e.From, err) | |
| "failed to parse lazy-rollover-exception to version '%s': %w", e.To, err) |
nit: typo
| from, err := parseLazyRolloverExceptionVersionRange(e.From) | ||
| if err != nil { | ||
| return upgradeTestConfig{}, fmt.Errorf( | ||
| "failed to parse lazy-rollover-exception version '%s': %w", e.From, err) |
There was a problem hiding this comment.
Suggested change
| "failed to parse lazy-rollover-exception version '%s': %w", e.From, err) | |
| "failed to parse lazy-rollover-exception from version '%s': %w", e.From, err) |
nit: clarity
carsonip
reviewed
Oct 10, 2025
| # ``` | ||
| # | ||
| # Both major and patch positions are not given the special wildcard (x) because | ||
| # it is unlikely to be useful in our use cases. If due to some mistake, the |
There was a problem hiding this comment.
If due to some mistake
non blocker: I wonder if it is just easier to ban it outright to avoid any misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Closes #17314.
Add a new way of defining lazy rollover exceptions.
How to test these changes
Run workflow: https://github.com/elastic/apm-server/actions/runs/18378244354.