-
Notifications
You must be signed in to change notification settings - Fork 540
test(logging): remove deprecated observeroutput #19693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kruskall
wants to merge
9
commits into
elastic:main
Choose a base branch
from
kruskall:test/remove-observer-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+24
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're using local loggers now and the observer output is unused
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
ericywl
previously approved these changes
Nov 25, 2025
replace panic with t.Fatal pass path.home to ensure we're using the same home without relying on global variables
Contributor
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-8
Automated backport with mergify to all the active 8.[0-9]+ branches
backport-active-9
Automated backport with mergify to all the active 9.[0-9]+ branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
we're using local loggers now and the observer output is unused and deprecated
solve lint failure on elastic-agent-libs version bump
Checklist
For functional changes, consider:
How to test these changes
make testRelated issues