creates the .aws home directory if it doesn't exist#3
Open
morganda wants to merge 1 commit intoelastic:masterfrom
morganda:create_home_aws_dir_if_not_exists
Open
creates the .aws home directory if it doesn't exist#3morganda wants to merge 1 commit intoelastic:masterfrom morganda:create_home_aws_dir_if_not_exists
morganda wants to merge 1 commit intoelastic:masterfrom
morganda:create_home_aws_dir_if_not_exists
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the initial setup so that it would create the $HOME/.aws directory as well as the credentials file if it doesn't exist to make initial setup a bit smoother. I can create tests for this if desired, but I didn't see any others so I passed for now. That said it worked fine locally - below you can see the output.
Additionally, I used f-strings, but I'm not sure if we want to maintain python2 compatibility. Thoughts?