metricbeat beat stats metricset fetch failure_store metric#49452
metricbeat beat stats metricset fetch failure_store metric#49452leehinman merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🔍 Preview links for changed docs |
26665b4 to
fe95caa
Compare
fe95caa to
87438f9
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis pull request adds the ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@elastic/stack-monitoring any chance you could review? |
|
@leehinman it looks good to Stack Monitoring, but do you have the corresponding PR in the ES repo to add the new field to the beats index templates? |
Thank You. Just opened: |
elastic/elasticsearch#144883 is merged now, anything else blocking this? |
|
@leehinman Thanks, looks good, fire away! |
|
@leehinman I think we should backport this to 9.4, WDYT? |
If you do, don't forget to also backport the PR in the elasticsearch repo |
@consulthys can you help me with the backport in the elasticsearch repo? I added "auto-backport" and "9.4.1" labels, but it looks like I'm missing a step. |
Oh I'm not sure if the backport labels work after the PR is merged and closed. I need to look closer into it Also noting that
|
(cherry picked from commit d1e97e9)
Proposed commit message
In Metricbeat beat modules, stats metricset collect the
failure_storemetric that was added in #48068Having
failure_storeas a metric in elastic-agent internal monitoring is a use case for this.Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Will add
failure_storefield tolibbeat.output.eventsAuthor's Checklist
How to test this PR locally
failure_storefailure_storeRelated issues
Use cases
Screenshots
Logs