Fix add_host_metadata host.geo map sharing across events#49722
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
Fix add_host_metadata host.geo map sharing across events#49722github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Clone cached geo data before DeepUpdate so per-event host.geo mutations cannot leak into subsequent events. Add a regression test that mutates host.geo on one event and verifies later events are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This pull request doesn't have a |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes
add_host_metadatageodata corruption caused by shared map reuse.When enriching events,
hostdata was cloned beforeDeepUpdate, butgeodata was not. BecauseDeepUpdatecan merge map values by reference, mutatinghost.geoin one processed event could affect later events.What changed
libbeat/processors/add_host_metadata/add_host_metadata.go, clone cached geo data before merging:event.Fields.DeepUpdate(p.geoData.Clone())libbeat/processors/add_host_metadata/add_host_metadata_test.go:TestGeoFieldsAreNotMutatedAcrossEventshost.geoon one event does not leak to a subsequent event.Validation
go test ./libbeat/processors/add_host_metadata -run TestGeoFieldsAreNotMutatedAcrossEventsgo test ./libbeat/processors/add_host_metadatafails in this CI container due to existing environment assumptions in pre-existing tests (no valid /etc/(distrib)-release file found), unrelated to this change.Notes
Change is intentionally minimal and behavior-preserving, except preventing cross-event
host.geomutation leakage.Fixes add_host_metadata Geodata Corruption #49721
Note
🔒 Integrity filtering filtered 1 item
Integrity filtering activated and filtered the following item during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.
issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)What is this? | From workflow: Mention in Issue
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.