Skip to content

Guard TCP input debug logging with IsDebug() to halve per-event allocations #49737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −8
Open

Guard TCP input debug logging with IsDebug() to halve per-event allocations #49737

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cad9445
Initial plan
Copilot Mar 27, 2026
61c2e9e
Guard TCP input debug logging with IsDebug() check
Copilot Mar 27, 2026
f677eb0
fix: resolve lint issues in tcp input
strawgate Mar 30, 2026
74dc9ae
Merge branch 'main' into copilot/reduce-per-event-allocations
strawgate Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions filebeat/input/net/tcp/input.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package tcp

import (
"context"
"fmt"
"net"
"time"
Expand Down Expand Up @@ -88,14 +89,14 @@ func newServer(config config) (*server, error) {
func (s *server) Name() string { return "tcp" }

func (s *server) Test(_ input.TestContext) error {
l, err := net.Listen("tcp", s.Host)
l, err := (&net.ListenConfig{}).Listen(context.Background(), "tcp", s.Host)
if err != nil {
return err
}
return l.Close()
}

// InitMetrics initalises and returns an netmetrics.TCP
// InitMetrics initialises and returns a netmetrics.TCP
func (s *server) InitMetrics(id string, reg *monitoring.Registry, logger *logp.Logger) netinput.Metrics {
s.metrics = netmetrics.NewTCP(reg, s.Host, time.Minute, logger)
return s.metrics
Expand All @@ -120,11 +121,13 @@ func (s *server) Run(ctx input.Context, evtChan chan<- netinput.DataMetadata, m
func(data []byte, metadata inputsource.NetworkMetadata) {
now := time.Now()
m.EventReceived(len(data), now)
ctx.Logger.Debugw(
"Data received",
"bytes", len(data),
"remote_address", metadata.RemoteAddr.String(),
"truncated", metadata.Truncated)
if ctx.Logger.IsDebug() {
ctx.Logger.Debugw(
"Data received",
"bytes", len(data),
"remote_address", metadata.RemoteAddr.String(),
"truncated", metadata.Truncated)
}

evtChan <- netinput.DataMetadata{
Data: data,
Expand All @@ -137,7 +140,7 @@ func (s *server) Run(ctx input.Context, evtChan chan<- netinput.DataMetadata, m
ctx.Logger,
)
if err != nil {
return fmt.Errorf("Failed to start TCP server: %w", err)
return fmt.Errorf("failed to start TCP server: %w", err)
}

ctx.Logger.Debug("tcp input initialized")
Expand Down
Loading