fix(ci): install mage via asdf if missing in pre-command hook#49776
Closed
orestisfl wants to merge 1 commit intoelastic:mainfrom
Closed
fix(ci): install mage via asdf if missing in pre-command hook#49776orestisfl wants to merge 1 commit intoelastic:mainfrom
orestisfl wants to merge 1 commit intoelastic:mainfrom
Conversation
The CI agent image (ci-agent-images) hardcodes mage 1.14.0, but all beats pipelines set ASDF_MAGE_VERSION: 1.15.0. The agent-level pre-command hook auto-installs Go, Python, and Node.js when missing but has no equivalent block for mage. Add an asdf install guard in the repo pre-command hook to ensure the required mage version is present before any step runs.
orestisfl
added
bug
automation
ci
backport-active-all
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
Contributor
🤖 GitHub commentsJust comment with:
|
📝 WalkthroughWalkthroughA pre-command hook step was added to ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.buildkite/hooks/pre-command (1)
31-34: Consider adding a Buildkite step separator for visibility.Other operations in this file use
echo "--- ..."format (e.g., line 26). Adding one here would make the mage installation visible in Buildkite logs.💡 Suggested change
# Ensure the required mage version is installed (the CI agent image may not have it) if [[ -n "${ASDF_MAGE_VERSION:-}" ]] && command -v asdf &>/dev/null; then + echo "--- Installing mage ${ASDF_MAGE_VERSION} via asdf" asdf install mage "$ASDF_MAGE_VERSION" fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.buildkite/hooks/pre-command around lines 31 - 34, Add a Buildkite step separator before the mage install so the installation is visible in logs: insert an echo '--- Installing mage' (or similar) immediately before the block that checks ASDF_MAGE_VERSION and runs command -v asdf, so the step around the existing asdf install mage "$ASDF_MAGE_VERSION" is clearly labeled in the Buildkite output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.buildkite/hooks/pre-command:
- Around line 31-35: The change adds an asdf-based mage install in the
pre-command hook but lacks a changelog fragment; generate a fragment using the
elastic-agent-changelog-tool (run: go install
github.com/elastic/elastic-agent-changelog-tool@latest and
elastic-agent-changelog-tool new "Install mage via asdf if missing in
pre-command hook"), place the generated file under changelog/fragments/, and set
metadata kind: bug-fix and component: ci (or appropriate component) so the PR
includes the required changelog entry referencing the pre-command hook change
that installs mage when ASDF_MAGE_VERSION is set.
---
Nitpick comments:
In @.buildkite/hooks/pre-command:
- Around line 31-34: Add a Buildkite step separator before the mage install so
the installation is visible in logs: insert an echo '--- Installing mage' (or
similar) immediately before the block that checks ASDF_MAGE_VERSION and runs
command -v asdf, so the step around the existing asdf install mage
"$ASDF_MAGE_VERSION" is clearly labeled in the Buildkite output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2a4587e4-24fd-4b12-bd8f-5afe1dabaccb
📒 Files selected for processing (1)
.buildkite/hooks/pre-command
Comment on lines
+31
to
+35
| # Ensure the required mage version is installed (the CI agent image may not have it) | ||
| if [[ -n "${ASDF_MAGE_VERSION:-}" ]] && command -v asdf &>/dev/null; then | ||
| asdf install mage "$ASDF_MAGE_VERSION" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Missing changelog fragment.
This bug fix should include a changelog fragment in changelog/fragments/. Create one via:
go install github.com/elastic/elastic-agent-changelog-tool@latest
elastic-agent-changelog-tool new "Install mage via asdf if missing in pre-command hook"Set kind: bug-fix and component: ci (or appropriate component). Based on learnings from this repository.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.buildkite/hooks/pre-command around lines 31 - 35, The change adds an
asdf-based mage install in the pre-command hook but lacks a changelog fragment;
generate a fragment using the elastic-agent-changelog-tool (run: go install
github.com/elastic/elastic-agent-changelog-tool@latest and
elastic-agent-changelog-tool new "Install mage via asdf if missing in
pre-command hook"), place the generated file under changelog/fragments/, and set
metadata kind: bug-fix and component: ci (or appropriate component) so the PR
includes the required changelog entry referencing the pre-command hook change
that installs mage when ASDF_MAGE_VERSION is set.
v1v
approved these changes
Mar 30, 2026
Contributor
Author
|
Closing to handle on the image instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds a guard in
.buildkite/hooks/pre-commandtoasdf install magethe required version if missing.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works.I have added an entry in./changelog/fragmentsRelated issues