Skip to content

[9.3](backport #49706) filebeat: port remaining harvester tests to filestream#49793

Merged
mauri870 merged 1 commit into9.3from
mergify/bp/9.3/pr-49706
Mar 30, 2026
Merged

[9.3](backport #49706) filebeat: port remaining harvester tests to filestream#49793
mauri870 merged 1 commit into9.3from
mergify/bp/9.3/pr-49706

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 30, 2026

Summary

Port the remaining test coverage from filebeat/tests/system/test_harvester.py into filebeat/input/filestream/input_integration_test.go, then remove the redundant Python test file.

Added Go integration tests

  • TestFilestreamExceedBuffer (from test_exceed_buffer)
  • TestFilestreamIgnoreSymlink (from test_ignore_symlink)
  • TestFilestreamSymlinkAndFile (from test_symlink_and_file)
  • TestFilestreamDecodeError (from test_decode_error)
  • TestFilestreamDebugReader (from test_debug_reader)

Other changes

  • Removed filebeat/tests/system/test_harvester.py.
  • Enabled debug selector setup in TestFilestreamDebugReader via logp.TestingSetup(logp.WithSelectors("*")) so null-byte debug logging is observable in the integration harness.

Validation

I attempted to run the new tests with repeated counts, but this runner consistently OOM-killed compilation of transitive dependencies in go test before executing tests:

  • GOMAXPROCS=1 GOGC=20 GOFLAGS='-p=1 -vet=off' go test -tags=integration ./filebeat/input/filestream -run '^TestFilestreamExceedBuffer$' -count=50
  • GOMAXPROCS=1 GOGC=20 GOFLAGS='-p=1 -vet=off' go test -tags=integration ./filebeat/input/filestream -run '^TestFilestreamIgnoreSymlink$' -count=50

Representative failure:

github.com/elastic/go-elasticsearch/v8/typedapi/types: .../compile: signal: killed
FAIL github.com/elastic/beats/v7/filebeat/input/filestream [build failed]

Given the environment memory limits, I could not complete the requested high -count flake validation here. The code changes are committed and ready for CI validation in a larger runner.

Note

🔒 Integrity filtering filtered 1 item

Integrity filtering activated and filtered the following item during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.


What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.


This is an automatic backport of pull request #49706 done by [Mergify](https://mergify.com).

* filebeat: port remaining harvester tests to filestream

Port remaining coverage from test_harvester.py into filestream input integration tests and remove the redundant Python test file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix linter issues

* fix test context

* fix issue with logger with no selectors

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit f558378)
@mergify mergify bot added the backport label Mar 30, 2026
@mergify mergify bot requested a review from a team as a code owner March 30, 2026 18:18
@mergify mergify bot requested review from AndersonQ and VihasMakwana and removed request for a team March 30, 2026 18:18
@mergify mergify bot added the backport label Mar 30, 2026
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions github-actions bot added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog ai labels Mar 30, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2026
@mauri870 mauri870 enabled auto-merge (squash) March 30, 2026 18:27
@mauri870 mauri870 merged commit a168807 into 9.3 Mar 30, 2026
49 of 50 checks passed
@mauri870 mauri870 deleted the mergify/bp/9.3/pr-49706 branch March 30, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants