FallbackManager WaitForStop calls Stop#49858
Conversation
Update the FallbackManager to call Stop in WaitForStop to be consistent with the method goal and all other implementations (real or mocks).
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
🤖 GitHub commentsJust comment with:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Proposed commit message
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works. Where relevant, I have used thestresstest.shscript to run them under stress conditions and race detector to verify their stability.I have added an entry in./changelog/fragmentsusing the changelog tool.## Disruptive User Impact## How to test this PR locallyRelated issues
BeatV2ManagerStartinto two methods, so Beats can reply to check-in in parallel to its initialisation #49796## Use cases~~## Screenshotsv
## Logs