Skip to content

FallbackManager WaitForStop calls Stop#49858

Open
belimawr wants to merge 1 commit intoelastic:mainfrom
belimawr:FallbackManager-call-stop-on-WaitForStop
Open

FallbackManager WaitForStop calls Stop#49858
belimawr wants to merge 1 commit intoelastic:mainfrom
belimawr:FallbackManager-call-stop-on-WaitForStop

Conversation

@belimawr
Copy link
Copy Markdown
Contributor

@belimawr belimawr commented Apr 1, 2026

Proposed commit message

Update the FallbackManager to call Stop in WaitForStop to be consistent with the method goal and all other implementations (real or mocks).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

## Disruptive User Impact
## How to test this PR locally

Related issues

## Use cases
~~## Screenshotsv
## Logs

Update the FallbackManager to call Stop in WaitForStop to be
consistent with the method goal and all other implementations (real or
mocks).
@belimawr belimawr self-assigned this Apr 1, 2026
@belimawr belimawr requested a review from a team as a code owner April 1, 2026 15:48
@belimawr belimawr requested review from blakerouse and samuelvl April 1, 2026 15:48
@belimawr belimawr added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog labels Apr 1, 2026
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22f41359-5c84-41e8-a576-34872aecabe2

📥 Commits

Reviewing files that changed from the base of the PR and between 5b32798 and 0c42046.

📒 Files selected for processing (1)
  • libbeat/management/management.go

📝 Walkthrough

Walkthrough

The WaitForStop() method in FallbackManager was updated to execute shutdown logic before returning. Previously, the method returned true immediately without triggering any stop operations. The modification adds a call to n.Stop() prior to the return statement, ensuring shutdown is actively initiated. The method signature and behavior of other FallbackManager methods remain unchanged. The modification affects 9 lines added and 6 lines removed.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 1, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants