Conversation
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughA blank import for ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TL;DR
Remediation
Investigation detailsRoot CauseThe PR relocates Evidence
VerificationNot run locally in this environment; diagnosis is based on the provided Buildkite failure log and repository make target behavior. Follow-upAfter fixing headers, if a subsequent job fails, share that next failing log and I can triage the next blocker. Note 🔒 Integrity filtering filtered 1 itemIntegrity filtering activated and filtered the following item during workflow execution.
What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
leehinman
left a comment
There was a problem hiding this comment.
What about licensing? otelconsumer is Elastic licensed.
@leehinman I checked with @cmacknz beforehand, he says (edit: but I do still need to add the new license headers to the moved files 😄) |
But I think that means you have to re-license otelconsomer to Apache license. I might be missing something but it looks like this PR just renames the files. The errors from |
Move
otelconsumerout of x-pack so it can be directly referenced elsewhere in libbeat. This is preparation for theoutputControllerchanges in #49679, which involve separatingotelconsumerfrom the general-purpose output API and using it directly from the OTel-specific output controller.This is just moving the package from one directory to another for symbol visibility, it involves no changes to behavior.