Skip to content

fix: update azeventhubs v2 import in v2_input_test.go#50051

Merged
zmoog merged 1 commit intoelastic:mainfrom
strawgate:fix-azeventhubs-v2-test-import
Apr 10, 2026
Merged

fix: update azeventhubs v2 import in v2_input_test.go#50051
zmoog merged 1 commit intoelastic:mainfrom
strawgate:fix-azeventhubs-v2-test-import

Conversation

@strawgate
Copy link
Copy Markdown
Contributor

@strawgate strawgate commented Apr 10, 2026

Summary

This was missed in #49867 and is currently breaking lint CI on all open PRs (e.g. #50022).

Test plan

  • Lint CI passes (the only change is fixing the broken import/type)
  • go vet ./x-pack/filebeat/input/azureeventhub/... passes (verified locally)

🤖 Generated with Claude Code

PR elastic#49867 upgraded the azeventhubs SDK to v2 but missed updating the
test file import path and Offset field types (int64 → string in v2).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@strawgate strawgate requested a review from a team as a code owner April 10, 2026 02:09
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a9f82ed-97ab-4553-8c9d-8b524a53dcb2

📥 Commits

Reviewing files that changed from the base of the PR and between df60c84 and 89be972.

📒 Files selected for processing (1)
  • x-pack/filebeat/input/azureeventhub/v2_input_test.go

📝 Walkthrough

Walkthrough

The test file imports the v2 version of the Azure SDK for Event Hubs. The TestProcessReceivedEventsUpdatesProcessingTimeOnce test updates mock ReceivedEventData objects to use string values ("0", "1", "2") for the Offset field instead of numeric values, reflecting the type changes in the v2 API. The test logic and assertions remain unchanged. No public entity declarations were modified.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@zmoog zmoog added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Apr 10, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2026
@zmoog zmoog added needs_team Indicates that the issue/PR needs a Team:* label input:azure-eventhub labels Apr 10, 2026
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2026
@zmoog
Copy link
Copy Markdown
Contributor

zmoog commented Apr 10, 2026

Ouch, what a failure. Thanks for fixing it, @strawgate. On it.

@zmoog zmoog merged commit f776d22 into elastic:main Apr 10, 2026
39 of 44 checks passed
@zmoog
Copy link
Copy Markdown
Contributor

zmoog commented Apr 10, 2026

This was missed in #49867 and is currently breaking lint CI on all open PRs (e.g. #50022).

I was curious to know why CI didn't catch this. It turns out the failure was caused by the interplay between two PRs, both of which were fine in isolation:

Staying synced with main (or using the merge queue) would have avoided this inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

input:azure-eventhub Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants