fix: update azeventhubs v2 import in v2_input_test.go#50051
fix: update azeventhubs v2 import in v2_input_test.go#50051zmoog merged 1 commit intoelastic:mainfrom
Conversation
PR elastic#49867 upgraded the azeventhubs SDK to v2 but missed updating the test file import path and Offset field types (int64 → string in v2). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test file imports the v2 version of the Azure SDK for Event Hubs. The ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Ouch, what a failure. Thanks for fixing it, @strawgate. On it. |
I was curious to know why CI didn't catch this. It turns out the failure was caused by the interplay between two PRs, both of which were fine in isolation:
Staying synced with main (or using the merge queue) would have avoided this inconsistency. |
Summary
v2_input_test.goafter the azeventhubs SDK v2 upgrade (x-pack/filebeat: upgrade azeventhubs SDK to v2.0.2 #49867)azeventhubstoazeventhubs/v2Offsetfield values fromint64tostring(v2 breaking change)This was missed in #49867 and is currently breaking lint CI on all open PRs (e.g. #50022).
Test plan
go vet ./x-pack/filebeat/input/azureeventhub/...passes (verified locally)🤖 Generated with Claude Code