Skip to content

[8.19](backport #3893) fix project metadata request#3944

Open
mergify[bot] wants to merge 2 commits into8.19from
mergify/bp/8.19/pr-3893
Open

[8.19](backport #3893) fix project metadata request#3944
mergify[bot] wants to merge 2 commits into8.19from
mergify/bp/8.19/pr-3893

Conversation

@mergify
Copy link

@mergify mergify bot commented Feb 11, 2026

Changes

  • add rate limiting for GCP Projects API to prevent 429 quota errors
  • add singleflight to deduplicate concurrent requests for the same project metadata

Context

  • a while ago i merged a PR to cache the org name so we don't get rate limited for the org api.
  • latest errors show we're hitting rate limit errors for project api, this is what this PR fixes
googleapi: Error 429: Quota exceeded for quota metric 'Project V3 get requests' 

The quota is 600 requests per minute. with many projects and assets arriving concurrently, we could exceed this before the cache was populated.


This is an automatic backport of pull request #3893 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner February 11, 2026 16:11
@mergify mergify bot assigned orouz Feb 11, 2026
@mergify
Copy link
Author

mergify bot commented Feb 11, 2026

Cherry-pick of 10e1725 has failed:

On branch mergify/bp/8.19/pr-3893
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 10e17250.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   internal/resources/fetching/fetchers/gcp/assets_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/assets_fetcher_test.go
	modified:   internal/resources/fetching/fetchers/gcp/log_sink_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/log_sink_fetcher_test.go
	modified:   internal/resources/fetching/fetchers/gcp/monitoring_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/monitoring_fetcher_test.go
	modified:   internal/resources/fetching/fetchers/gcp/networks_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/networks_fetcher_test.go
	modified:   internal/resources/fetching/fetchers/gcp/policies_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/policies_fetcher_test.go
	modified:   internal/resources/fetching/fetchers/gcp/service_usage_fetcher.go
	modified:   internal/resources/fetching/fetchers/gcp/service_usage_fetcher_test.go
	modified:   internal/resources/providers/gcplib/inventory/resource_manager.go
	modified:   internal/resources/providers/gcplib/inventory/resource_manager_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

(cherry picked from commit 10e1725)
@orouz orouz force-pushed the mergify/bp/8.19/pr-3893 branch from 426db1a to 18333f0 Compare February 15, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant