Skip to content

Update ATT&CK coverage URL(s) in docs-dev/ATT&CK-coverage.md#4731

Merged
shashank-elastic merged 2 commits intomainfrom
update-attack-coverage-82bee3e9c
May 20, 2025
Merged

Update ATT&CK coverage URL(s) in docs-dev/ATT&CK-coverage.md#4731
shashank-elastic merged 2 commits intomainfrom
update-attack-coverage-82bee3e9c

Conversation

@github-actions
Copy link
Contributor

Update ATT&CK coverage URL(s) in docs-dev/ATT&CK-coverage.md

  • Autogenerated from job attack-coverage-update: pr.

@shashank-elastic shashank-elastic added enhancement New feature or request patch labels May 20, 2025
@github-actions
Copy link
Contributor Author

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the enhancement does not break existing functionality.
  • Review the enhancement with a peer or team member for additional insights.
  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.
  • Confirm that the proper version label is applied to the PR patch, minor, major.

@shashank-elastic shashank-elastic requested a review from a team May 20, 2025 02:06
@shashank-elastic shashank-elastic merged commit 5832aec into main May 20, 2025
26 of 27 checks passed
@shashank-elastic shashank-elastic deleted the update-attack-coverage-82bee3e9c branch May 20, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants