-
Notifications
You must be signed in to change notification settings - Fork 603
[Rule Tuning] Update Azure / M365 Rule Names and File Paths #5172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Rule Tuning] Update Azure / M365 Rule Names and File Paths #5172
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
rules/integrations/azure/defense_evasion_automation_runbook_deleted.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/execution_automation_runbook_created_or_modified.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/persistence_automation_account_created.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/impact_key_vault_modified_by_unusual_user.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/initial_access_entra_id_protection_sign_in_risk_detected.toml
Outdated
Show resolved
Hide resolved
…gn_in_risk_detected.toml
rules/integrations/o365/initial_access_defender_for_m365_threat_intelligence_signal.toml
Outdated
Show resolved
Hide resolved
rules/integrations/o365/collection_onedrive_excessive_file_downloads.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/persistence_event_hub_created_or_updated.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/persistence_entra_id_mfa_disabled_for_user.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/persistence_entra_id_global_administrator_role_assigned.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/persistence_automation_webhook_created.toml
Outdated
Show resolved
Hide resolved
rules/integrations/azure/initial_access_entra_id_protection_user_risk_detected.toml
Outdated
Show resolved
Hide resolved
…er_risk_detected.toml
…ator_role_assigned.toml
…t_intelligence_signal.toml
Note: Not merging until we coordinate internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! Since you're normalizing naming conventions. Your brute force rules alternated between Brute Force "Attempt" and Brute Force "Attempted". I suggested Attempted because it seems to align more with the past tense nature of the rest of the rule names. But this is definitely a nit suggestion. Everything looks good!
language = "esql" | ||
license = "Elastic License v2" | ||
name = "Potential Microsoft 365 User Account Brute Force" | ||
name = "M365 Identity User Brute Force Attempt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "M365 Identity User Brute Force Attempt" | |
name = "M365 Identity User Brute Force Attempted" |
note = """## Triage and Analysis | ||
### Investigating Potential Microsoft 365 User Account Brute Force | ||
### Investigating M365 Identity User Brute Force Attempt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Investigating M365 Identity User Brute Force Attempt | |
### Investigating M365 Identity User Brute Force Attempted |
language = "esql" | ||
license = "Elastic License v2" | ||
name = "Microsoft 365 Brute Force via Entra ID Sign-Ins" | ||
name = "Entra ID Sign-in Brute Force Attempt (Microsoft 365)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "Entra ID Sign-in Brute Force Attempt (Microsoft 365)" | |
name = "Entra ID Sign-in Brute Force Attempted (Microsoft 365)" |
note = """## Triage and analysis | ||
### Investigating Microsoft 365 Brute Force via Entra ID Sign-Ins | ||
### Investigating Entra ID Sign-in Brute Force Attempt (Microsoft 365) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Investigating Entra ID Sign-in Brute Force Attempt (Microsoft 365) | |
### Investigating Entra ID Sign-in Brute Force Attempted (Microsoft 365) |
Pull Request
Issue link(s):
Summary - What I changed
Standardizes rule names for Azure and M365 based on guidelines established in the related issue. Only file names, rule names and investigation guide headers were adjusted. For a comprehensive list of all Azure and M365 rules, please see the related issue.
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist