-
Notifications
You must be signed in to change notification settings - Fork 603
[New Rule] Azure Compute Snapshot Deletion(s) #5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Rule: New - GuidelinesThese guidelines serve as a reminder set of considerations when proposing a new rule. Documentation and Context
Rule Metadata Checks
New BBR Rules
Testing and Validation
|
|
||
[rule.new_terms] | ||
field = "new_terms_fields" | ||
value = ["azure.activitylogs.identity.claims_initiated_by_user.name", "azure.resource.group"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so is azure.resource.group
something that is created for a group of snapshots in this case? I'm wondering why you need both fields here instead of just the azure.activitylogs.identity.claims_initiated_by_user.name
field? Are you intending to capture the first time a user deletes any snapshot inside of a particular group of snapshots?
event.dataset: azure.activitylogs and | ||
azure.activitylogs.operation_name: "MICROSOFT.COMPUTE/SNAPSHOTS/DELETE" and | ||
azure.activitylogs.properties.status_code: "Accepted" and | ||
azure.activitylogs.identity.claims_initiated_by_user.name: * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there ever an instance where
azure.activitylogs.identity.claims_initiated_by_user.name
field isn't populated? - Is
azure.activitylogs.result_type: Accept
orazure.activitylogs.result_signature: Accepted.Accepted
equivalent toazure.activitylogs.properties.status_code: Accepted
? If so should you use one of these in the query in place of the flattened field?
query = ''' | ||
event.dataset: azure.activitylogs and | ||
azure.activitylogs.operation_name: "MICROSOFT.COMPUTE/SNAPSHOTS/DELETE" and | ||
azure.activitylogs.properties.status_code: "Accepted" and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here about the use of a flattened field
Fixes #5210
Pull Request
Issue link(s):
Summary - What I changed
Adds detection coverage for unusual Azure Compute snapshot deletions. A threshold rule and a New Terms rule. Please see related issue for more details.
How To Test
Query can be used to test on data in TRADE stack.
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist