[Rule Tuning] Add Missing Metadata to KEEP conditions #5442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
requested review from
Aegrah,
Mikaayenson,
Samirbous,
imays11,
shashank-elastic and
terrancedejesus
botelastic
bot
added
Domain: Cloud
Integration: AWS
Contributor
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
Contributor
|
I think the rule |
Contributor
Author
|
++ I skipped it initially as I wasn't adding the other 2, I'll add it |
botelastic
bot
added
bbr
|
⛔️ Test failed Results
|
Contributor
Author
|
@eric-forte-elastic that one will be addressed by #5439 |
|
⛔️ Test failed Results
|
w0rk3r
commented
Dec 9, 2025
rules_building_block/discovery_ec2_multi_region_describe_instances.toml
Outdated
Show resolved
Hide resolved
|
⛔️ Test failed Results
|
eric-forte-elastic
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
🟢 Manual review, looks good to me! 👍
When this branch and rt_0 are pulled into #5441, the tests there pass.
Details
detection-rules on 5440-fr-unit-test-for-keep-metadata [!?⇡] is v1.5.23 via v3.12.12 (detection-rules-build) on eric.forte
❯ git checkout origin/rt_1 -- rules
detection-rules on 5440-fr-unit-test-for-keep-metadata [!?⇡] is v1.5.23 via v3.12.12 (detection-rules-build) on eric.forte
❯ python -m detection_rules test
Loaded config file: /tmp/detection-rules/.detection-rules-cfg.json
...
tests/test_version_locking.py::TestVersionLock::test_previous_entries_gte_current_min_stack PASSED [100%]
================================================================================================== warnings summary ===================================================================================================
env/detection-rules-build/lib/python3.12/site-packages/_pytest/config/__init__.py:1303
env/detection-rules-build/lib/python3.12/site-packages/_pytest/config/__init__.py:1303
/tmp/detection-rules/env/detection-rules-build/lib/python3.12/site-packages/_pytest/config/__init__.py:1303: PytestAssertRewriteWarning: Module already imported so cannot be rewritten; typeguard
self._mark_plugins_for_rewrite(hook, disable_autoload)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=============================================================================== 171 passed, 14 skipped, 2 warnings in 159.82s (0:02:39) ===============================================================================
detection-rules on 5440-fr-unit-test-for-keep-metadata [!?⇡] is v1.5.23 via v3.12.12 (detection-rules-build) on eric.forte took 2m44s
Samirbous
approved these changes
Dec 9, 2025
|
⛔️ Test failed Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Related to:
Summary
Adds
_id,_versionand_indexto the KEEP condition.