Skip to content

Added logic to main.py to use the created_at and updated_at values if they exist #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarju wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added logic to main.py to use the created_at and updated_at values if they exist #5444

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d0294f
Added logic to main.py to use the created_at and updated_at values fr…
aarju Dec 10, 2025
df1fa3b
Add comment for parsing created_at and updated_at fields to metadata
aarju Dec 10, 2025
7c1d80a
updated the date metadata code based on PR feedback
aarju Dec 10, 2025
2878bca
Merge branch 'elastic:main' into update-date-metadata-logic
aarju Dec 10, 2025
0276aa9
Merge branch 'main' into update-date-metadata-logic
aarju Dec 12, 2025
9310395
Add --dates-import option to rule import command
aarju Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions detection_rules/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,23 @@ def import_rules_into_repo( # noqa: PLR0912, PLR0913, PLR0915
if isinstance(contents["author"], str):
contents["author"] = [contents["author"]]

# Parse created_at and updated_at to creation_date and updated_date if they exist in contents
if "created_at" in contents:
Copy link
Contributor

@eric-forte-elastic eric-forte-elastic Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using these try, except blocks, it would be better to match the style/formatting we use in this function by using .get(). The addition is smaller and does not need to add additional exception handling.

It could look something like this instead for this PR:

        # Parse created_at and updated_at to creation_date and updated_date if they exist in contents
        now = datetime.now(UTC).strftime("%Y-%m-%dT%H:%M:%S.%fZ")
        contents["creation_date"] = datetime.strptime(
            contents.get("created_at", now), "%Y-%m-%dT%H:%M:%S.%fZ"
        ).strftime("%Y/%m/%d")
        contents["updated_date"] = datetime.strptime(contents.get("updated_at", now), "%Y-%m-%dT%H:%M:%S.%fZ").strftime(
            "%Y/%m/%d"
        )

Copy link
Author

@aarju aarju Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help, I just updated the functions to use the .get() function using your code.

try:
contents["creation_date"] = datetime.strptime(
contents["created_at"], "%Y-%m-%dT%H:%M:%S.%fZ"
).strftime("%Y/%m/%d")
except ValueError:
pass

if "updated_at" in contents:
try:
contents["updated_date"] = datetime.strptime(
contents["updated_at"], "%Y-%m-%dT%H:%M:%S.%fZ"
).strftime("%Y/%m/%d")
except ValueError:
pass

contents.update(
update_metadata_from_file(
rule_path, {"creation_date": local_creation_date, "updated_date": local_updated_date}
Expand Down
Loading