Skip to content

Fix crosslinks #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025
Merged

Fix crosslinks #1458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75b4929
Fix crosslinks
reakaleek Jun 26, 2025
af0316e
Revert to absolute URL
reakaleek Jun 26, 2025
30da4e2
Fix test
reakaleek Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ private static void ProcessCrossLink(LinkInline link, InlineProcessor processor,
if (context.CrossLinkResolver.TryResolve(
s => processor.EmitError(link, s),
uri, out var resolvedUri)
)
link.Url = resolvedUri.ToString();
)
link.Url = resolvedUri.AbsolutePath;
}

private static void ProcessInternalLink(LinkInline link, InlineProcessor processor, ParserContext context)
Expand Down
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Myst/Renderers/HtmxLinkInlineRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ protected override void Write(HtmlRenderer renderer, LinkInline link)
{
var currentRootNavigation = link.GetData(nameof(MarkdownFile.NavigationRoot)) as INodeNavigationItem<INavigationModel, INavigationItem>;
var targetRootNavigation = link.GetData($"Target{nameof(MarkdownFile.NavigationRoot)}") as INodeNavigationItem<INavigationModel, INavigationItem>;
var hasSameTopLevelGroup = !isCrossLink && (currentRootNavigation?.Id == targetRootNavigation?.Id);
var hasSameTopLevelGroup = !isCrossLink && currentRootNavigation?.Id == targetRootNavigation?.Id;
_ = renderer.Write($" hx-select-oob=\"{Htmx.GetHxSelectOob(hasSameTopLevelGroup)}\"");
_ = renderer.Write($" preload=\"{Htmx.Preload}\"");
}
if (isHttpLink && !isCrossLink)
if (isHttpLink)
{
_ = renderer.Write(" target=\"_blank\"");
_ = renderer.Write(" rel=\"noopener noreferrer\"");
Expand Down
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/Renderers/WrappedTableRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class WrappedTableRenderer : HtmlTableRenderer
protected override void Write(HtmlRenderer renderer, Table table)
{
// Wrap the table in a div to allow for overflow scrolling
_ = renderer.Write("<div class=\"table-wrapper\" hx-disable=\"true\">");
_ = renderer.Write("<div class=\"table-wrapper\">");
base.Write(renderer, table);
_ = renderer.Write("</div>");
}
Expand Down
Loading