Skip to content

add ECCTL to release notes nav #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2025
Merged

add ECCTL to release notes nav #1511

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f2593c
add ecctl to release notes nav
shainaraskas Jul 2, 2025
b6436c3
bump ecctl current
shainaraskas Jul 2, 2025
d69ae40
Remove comments from assembler.yml
bmorelli25 Jul 2, 2025
450b51b
Update legacy-url-mappings.yml
bmorelli25 Jul 2, 2025
3561bfb
Update legacy-url-mappings.yml
bmorelli25 Jul 2, 2025
3a9965e
Update legacy-url-mappings.yml
bmorelli25 Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tooling/docs-assembler/assembler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ narrative:
# cloud:
Copy link
Member

@bmorelli25 bmorelli25 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shainaraskas I think this is the wrong file. @reakaleek we should remove these comments to avoid confusion.

This is defined here:

docs-builder/src/Elastic.Documentation.Configuration/versions.yml

Line 26 in e55ea1b

current: 1.15

It looks like we already have 1.15.0 marked as current.

Copy link
Member

@bmorelli25 bmorelli25 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to move versioning out of assembler.yml as it is needed for individual repo builds as well.

Copy link
Member

@reakaleek reakaleek Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw! Clean up will follow.

Copy link
Contributor Author

@shainaraskas shainaraskas Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my b everyone.

Copy link
Member

@reakaleek reakaleek Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1512

Copy link
Member

@reakaleek reakaleek Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait. This is where it get's confusing.

the versions.yml is currently only for the applies_to tags.

we need to modify the legacy-mapping-url.yml for the dropdown.

Copy link
Member

@bmorelli25 bmorelli25 Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 450b51b

Copy link
Member

@reakaleek reakaleek Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 1.13 link anywhere?

Copy link
Member

@bmorelli25 bmorelli25 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on zoom. Fixed in 3a9965e

# current: 'current'
# ecctl:
# current: '1.14.3' # https://github.com/elastic/ecctl/releases
# current: '1.15.0' # https://github.com/elastic/ecctl/releases
# ecs_logging:
# current: 'current'
# ecs_logging_dotnet:
Expand Down
7 changes: 7 additions & 0 deletions src/tooling/docs-assembler/navigation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,14 @@ toc:
# https://github.com/elastic/docs-content/blob/main/release-notes/elastic-cloud-serverless/toc.yml
- toc: docs-content://release-notes/elastic-cloud-serverless
path_prefix: release-notes/cloud-serverless

# Cloud Hosted
# https://github.com/elastic/cloud/blob/master/docs/release-notes/cloud-hosted/toc.yml
# We probably need to add `max_toc_depth: 2` to
# https://github.com/elastic/cloud/blob/master/docs/docset.yml
- toc: cloud://release-notes/cloud-hosted
path_prefix: release-notes/cloud-hosted

# Cloud Enterprise
# https://github.com/elastic/cloud/blob/master/docs/release-notes/cloud-enterprise/toc.yml
- toc: cloud://release-notes/cloud-enterprise
Expand Down Expand Up @@ -204,6 +206,11 @@ toc:
- toc: ecs://release-notes
path_prefix: release-notes/ecs

# ECCTL
# https://github.com/elastic/ecctl/blob/master/docs/release-notes/toc.yml
- toc: ecctl://release-notes
path_prefix: release-notes/ecctl

#############
# REFERENCE #
#############
Expand Down
Loading