Allow dangling toc definitions in navigation.yml #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
commented
Jul 8, 2025
| { | ||
| navigationRoot = null; | ||
| navigationRootSource = null; | ||
| if (!assembleSources.TocTopLevelMappings.TryGetValue(navigationSource, out var topLevelMapping)) |
Member
Author
There was a problem hiding this comment.
Long term all of this will go away and we can just query the navigation itself..
reakaleek
approved these changes
Jul 8, 2025
Member
reakaleek
left a comment
reakaleek
left a comment
There was a problem hiding this comment.
LGTM.
I tested it locally and it fixes the missing navigation in opentelemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows documentation sets to use
toc.ymlfiles for grouping purposes without them being declared innavigation.ymlas long as their parent navigation element is.This leniency allows for e.g
docs-contentto partition docs folders for other teams without those teams having to worry about the larger navigation.