Skip to content

Add ConfigurationExporter to export all configurations to a central location. #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2025
Merged

Add ConfigurationExporter to export all configurations to a central location. #1568

merged 7 commits into from
Jul 17, 2025

Conversation

@Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jul 16, 2025 •
edited
Loading

In preparation of separating configuration from releases.

ls -al .artifacts/assembly/config/

drwxr-xr-x  5 mpdreamz  staff    160 Jul 16 16:01 ./
drwxr-xr-x  5 mpdreamz  staff    160 Jul 16 16:01 ../
-rw-r--r--  1 mpdreamz  staff   2909 Jul 14 11:24 assembler.yml
-rw-r--r--  1 mpdreamz  staff   3715 Jul  7 12:40 legacy-url-mappings.yml
-rw-r--r--  1 mpdreamz  staff  27434 Jul 16 15:36 navigation.yml

This also centralize our reading of configuration files in one location to make it easier to swap it out for something remote later.

All configuration files now live under /config in our codebase so external contributors do not need to hunt for these files.

@Mpdreamz
Add ConfigurationExporter to export all congigurations to a central l…
47157a3 
…ocation.

In preparation of separating configuration from releases.
@Mpdreamz Mpdreamz requested a review from a team as a code owner July 16, 2025 14:11
@Mpdreamz Mpdreamz self-assigned this Jul 16, 2025
reakaleek
reakaleek approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need the versions.yml config?

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Jul 17, 2025

yes we do!

@Mpdreamz Mpdreamz requested a review from a team as a code owner July 17, 2025 13:43
@github-actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

🔍 Preview links for changed docs

@Mpdreamz Mpdreamz requested a review from reakaleek July 17, 2025 14:18
@Mpdreamz Mpdreamz changed the title Add ConfigurationExporter to export all congigurations to a central location. Add ConfigurationExporter to export all configurations to a central location. Jul 17, 2025
@Mpdreamz Mpdreamz merged commit 48cd485 into main Jul 17, 2025
17 checks passed
@Mpdreamz Mpdreamz deleted the feature/config-export branch July 17, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reakaleek reakaleek Awaiting requested review from reakaleek

Assignees

@Mpdreamz Mpdreamz

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mpdreamz @reakaleek