Skip to content

Better approach to set the title on directives in LLM markdown output #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2025
Merged

Better approach to set the title on directives in LLM markdown output #1596

merged 5 commits into from
Jul 21, 2025

Conversation

@reakaleek
Copy link
Member

@reakaleek reakaleek commented Jul 21, 2025 •
edited
Loading

Changes

  • Set missing title for Stepper StepBlock.
  • Refactor how the LlmDirectiveRenderer determines if it needs to render a title attribute

@reakaleek reakaleek requested a review from a team as a code owner July 21, 2025 20:51
@reakaleek reakaleek added the fix label Jul 21, 2025
@reakaleek reakaleek self-assigned this Jul 21, 2025
@reakaleek reakaleek enabled auto-merge (squash) July 21, 2025 20:52
Mpdreamz
Mpdreamz approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer IBlockTitle but LGTM

@reakaleek reakaleek disabled auto-merge July 21, 2025 21:20
@reakaleek
Copy link
Member Author

reakaleek commented Jul 21, 2025

Would prefer IBlockTitle but LGTM

72250cb

@reakaleek reakaleek enabled auto-merge (squash) July 21, 2025 21:22
@reakaleek reakaleek merged commit 408c009 into main Jul 21, 2025
17 checks passed
@reakaleek reakaleek deleted the feature/fix-stepper-step-title branch July 21, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reakaleek @Mpdreamz