Add crosslinks to toc: in docset.yml #1615
Open
+307
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
|
@Mpdreamz @bmorelli25 Wanted to give this one a try. Seems to work (check the Testing section, last two items). If the code is ugly, please feel free to salvage whatever looks useful in this PR, or commit directly. |
Mpdreamz
requested changes
Jul 28, 2025
| // Log the error but don't fail the build | ||
| Context.EmitError(Context.ConfigurationPath, $"Error validating cross-links in navigation: {e.Message}"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Move this routine to Resolve() which could be made async.
There was a problem hiding this comment.
Which Resolve()? Tree.Resolve?
src/Elastic.Markdown/IO/Navigation/NavigationCrossLinkValidator.cs
Outdated
Show resolved
Hide resolved
src/Elastic.Markdown/IO/Navigation/NavigationCrossLinkValidator.cs
Outdated
Show resolved
Hide resolved
|
@Mpdreamz Anything missing for this one? Minus the remaining comment. |
|
Not sure @theletterf, I need some time to get to this PR still :) |
|
No probs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds crosslinks as accepted item types in docset.yml toc directives.
For example: