Skip to content

Set up api #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 31, 2025
Merged

Set up api #1662

merged 20 commits into from
Jul 31, 2025

Conversation

@reakaleek
Copy link
Member

@reakaleek reakaleek commented Jul 31, 2025 •
edited
Loading

Changes

  • Set up Elastic.Documentation.Api.* projects
  • Uses minimal api that is supposed to be deployed in AWS lambda
  • Currently only the LLMgateway proxy is implemented
  • The DocumentationWebhost.cs shares the setup.

@reakaleek reakaleek self-assigned this Jul 31, 2025
@reakaleek reakaleek marked this pull request as ready for review July 31, 2025 13:59
@reakaleek reakaleek requested a review from a team as a code owner July 31, 2025 13:59
Mpdreamz
Mpdreamz reviewed Jul 31, 2025
View reviewed changes
src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/useLlmGateway.ts Outdated
threadId,
})

// return LlmGatewayRequestSchema.parse({
Copy link
Member

@Mpdreamz Mpdreamz Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code still necessary?

Copy link
Member Author

@reakaleek reakaleek Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 45d895e

Mpdreamz
Mpdreamz approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely in love with the .Core and .Infrastructure grouping but lets circle back to it as this service unfolds.

Let's get it in so I can make it part of #1664 too.

Super exited about pulling the first public facing non static piece of infracture :)

@reakaleek
Copy link
Member Author

reakaleek commented Jul 31, 2025

I am not entirely in love with the .Core and .Infrastructure grouping but lets circle back to it as this service unfolds.

Let's get it in so I can make it part of #1664 too.

Super exited about pulling the first public facing non static piece of infracture :)

Thanks! I'll try to apply vertical slices in a follow-up!

@reakaleek reakaleek enabled auto-merge (squash) July 31, 2025 20:56
@reakaleek reakaleek merged commit 484338d into main Jul 31, 2025
18 checks passed
@reakaleek reakaleek deleted the feature/setup-clean-architecture-api branch July 31, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reakaleek @Mpdreamz