Skip to content

Make diff validate return 0 if redirect file does not exist #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Make diff validate return 0 if redirect file does not exist #1734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9098155
Make diff validate return 0 if redirect file does not exist
Mpdreamz Aug 13, 2025
27a4b19
remove other hashFiles usage
Mpdreamz Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/preview-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ jobs:
- name: 'Validate redirect rules'
if: >
env.MATCH == 'true'
&& ${{ hashFiles('docs/_redirects.yml', 'docs/redirects.yml') != '' }}
&& github.repository == 'elastic/docs-builder'
&& (
steps.deployment.outputs.result
Expand All @@ -315,7 +314,7 @@ jobs:
- name: 'Validate redirect rules'
if: >
env.MATCH == 'true'
&& ${{ hashFiles('docs/_redirects.yml', 'docs/redirects.yml') != '' }}
&& hashFiles('docs/_redirects.yml', 'docs/redirects.yml') != ''
&& (
github.repository != 'elastic/docs-builder'
&& (
Expand Down
5 changes: 5 additions & 0 deletions src/tooling/docs-builder/Cli/DiffCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ public async Task<int> ValidateRedirects([Argument] string? path = null, Cancel
var sourceFile = buildContext.ConfigurationPath;
var redirectFileName = sourceFile.Name.StartsWith('_') ? "_redirects.yml" : "redirects.yml";
var redirectFileInfo = sourceFile.FileSystem.FileInfo.New(Path.Combine(sourceFile.Directory!.FullName, redirectFileName));
if (!redirectFileInfo.Exists)
{
await collector.StopAsync(ctx);
return 0;
}

var redirectFileParser = new RedirectFile(redirectFileInfo, buildContext);
var redirects = redirectFileParser.Redirects;
Expand Down
Loading