Patch CrossLinkFetcher with Diagnostics Collector #1747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… registered to the workflow.
Mpdreamz
requested changes
Aug 18, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
I think this is no longer needed after our catch all uncaught exception fix. Throwing exceptions only is sufficient here and we want it to halt the program if we can't resolve the link files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the RCA for the downtime on August 16th, it was identified that docs-assembler did not register an error in the workflow, which was allowed to proceed and led to the docs website data being deleted.
This PR injects a DiagnosticsCollector and ensures code paths that throw an exception during data fetches register an error.