-
Notifications
You must be signed in to change notification settings - Fork 26
Adds table to dynamic tag logic explanation #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
szabosteve
wants to merge
4
commits into
main
Choose a base branch
from
szabosteve/applies-to-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ Specifically for versioned products, badges will display differently when the `a | |
* `Deprecation planned` (if the lifecycle is deprecated) | ||
|
||
Example: {applies_to}`stack: deprecated 99.99` | ||
* `Removal planned` (if the lifecycle is removed) | ||
* `Removal planned` (if the lifecycle is removed) | ||
|
||
Example: {applies_to}`stack: removed 99.99` | ||
|
||
|
@@ -18,3 +18,18 @@ When multiple lifecycle statuses and versions are specified in the sources, seve | |
:::{note} | ||
Visuals and wording in the output documentation are subject to changes and optimizations. | ||
::: | ||
Comment on lines
18
to
20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd also move this note down to the bottom |
||
|
||
The following table shows how the badge text and corresponding tooltip text vary by release status for each lifecycle value. Hoover over the example badges for tooltip text. | ||
|
||
| Lifecycle | Release status | Badge text | | ||
|-------------|----------------|-----------------------------------------------------------------------------------| | ||
| preview | prerelease | Planned | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these can have examples too. just set the version to 99.99 |
||
| | post-release | `<KEY> PREVIEW <VERSION>` <br><br> example: {applies_to}`stack: preview 9.1` | | ||
| beta | prerelease | Planned | | ||
| | post-release | `<KEY> BETA <VERSION>` <br><br> example: {applies_to}`stack: beta 9.1` | | ||
| ga | prerelease | Planned | | ||
| | post-release | `<KEY> <VERSION>` <br><br> example: {applies_to}`stack: ga 9.1` | | ||
| deprecated | prerelease | Deprecation planned | | ||
| | post-release | `<KEY> DEPRECATED <VERSION>` <br><br> example: {applies_to}`stack: deprecated 9.1`| | ||
| removed | prerelease | Removal planned | | ||
| | post-release | `<KEY> REMOVED <VERSION>` <br><br> example: {applies_to}`stack: removed 9.1` | |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove these bullets in favor of the table below + kind of rework the content so it's introducing the table instead