Upload links.json to s3 #176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Jan 13, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Codewise this looks great!
I do think this would be better off in an isolated binary. Purely to keep dependencies in docs-builder itself light.
Member
Author
|
We decided to use the aws cli in the github actions workflow for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to upload the links.json file to the Link Index (s3 bucket) for later validation.
Changes
This adds the
--upload-to-link-indexoption, which uploads the links.json file to the s3 bucket.It only happens under certain conditions, e.g.:
GITHUB_REPOSITORYenvironment variable