Add --delete-threshold to deploy plan with some sane defaults.
#1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `deleteThreshold` parameter with a default value of 0.2 - Added plan validation for deletion ratio before writing the plan. We will now fail and exit with a non zero exit code when the plan includes more deletions than the allowed ratio (0.2) or when the plan had no source files to begin with.
- Update delete ratio calculation to use `TotalSyncRequests` instead of `TotalFilesToSync`. - Enforce stricter delete thresholds for low `TotalSyncRequests` (<100: 0.8, <1000: 0.5) to accommodate higher flux in new documentation.
Mpdreamz
changed the title
deploy plan with some sane defaults.
cotti
approved these changes
Aug 26, 2025
Contributor
|
on board with 20% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds thresholds to our incremental deploy plan generation
TotalSyncRequests(<=100: 0.8, <=1000: 0.5, >1000: 0.2)`--delete-thresholdto ourdeploy plancommand. This will allow us to override the default threshold and force a manual deploy to go through if its legitimately exceeding the threshold.Includes a bunch of data driven tests to validate several scenarios.
@elastic/docs-tech-leads this will mean a single update can at most delete
20%of the content. Is that too stringent?