-
Notifications
You must be signed in to change notification settings - Fork 32
Highlight current section in the nav #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The padding looks off to me. There is much more padding on the right side. |
@reakaleek How about now? ![]() |
maybe that's bit nitpicky.. but IMO the grey box should align with the top dropdown box. should it also have the same border radius? |
Using -15px -0px -15px -15px: ![]() @reakaleek how about now? |
Can we create an inner box on hover of each item (white)? that stays active when selected? Thank you for this PR @theletterf! |
We would need grey-15 😄 |
@Mpdreamz @reakaleek Added hover effect! |
General question: Should we have any other kind of highlighting when the user goes further in the navigation tree menu? Or is just the first level there enough? |
@cotti Hmm, not sure. Right now the entire section (all parents) get highlighted. I think this is the same behavior as in the old docs. What are you picturing? |
@reakaleek Cleaner and more modern, more Vercel style: ![]() Though it would not solve the problem of highlighting the entire context. I'm fine with whatever we decide, though. |
unless, the "current" line has a different color. let me try something. |
Closing in favor of #2051 (comment) |
Fixes #1998
Test: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/2026/building-blocks/
This PR was entirely authored using Claude CLI with Claude 4.5 with some direct human intervention.