Skip to content

Quiet console capture until the last attempt #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Quiet console capture until the last attempt #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ navigation_title: Elastic Docs v3

# Welcome to Elastic Docs v3

Elastic Docs V3 is our next-generation documentation platform designed to improve the experience of learning, using, and contributing to Elastic products. Built on a foundation of modern authoring tools and scalable infrastructure, V3 offers faster builds, streamlined versioning, and enhanced navigation to guide users through Elastic’s complex ecosystem.
Elastic Docs V3 is our next-generation documentation platform designed to improve the experience of learning, using, and contributing to Elastic products. Built on a foundation of modern authoring tools and scalable infrastructure, V3 offers faster builds, streamlined versioning, and enhanced navigation to guide users through Elastic’s complex ecosystem.

## What do you want to do today?

Expand Down
4 changes: 2 additions & 2 deletions src/Elastic.Documentation/ExternalCommands/ExternalCommandExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ private string[] CaptureMultiple(bool muteExceptions, int attempts, string binar
}
catch (Exception ex)
{
collector.EmitGlobalWarning($"An exception occurred on attempt {i} to capture output of {binary}: {ex?.Message}");
if (ex is not null)
e = ex;
}
Expand All @@ -84,7 +83,8 @@ string[] CaptureOutput(Exception? previousException, int iteration, int max)
WorkingDirectory = workingDirectory.FullName,
Timeout = TimeSpan.FromSeconds(3),
WaitForExit = TimeSpan.FromSeconds(3),
ConsoleOutWriter = new ConsoleOutWriter()
// Capture the output of the command if it's the last iteration
ConsoleOutWriter = iteration == max ? new ConsoleOutWriter() : NoopConsoleWriter.Instance,
};
var result = Proc.Start(arguments);

Expand Down
Loading