-
Notifications
You must be signed in to change notification settings - Fork 32
Add synonyms.yml #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synonyms.yml #2091
Conversation
|
do you want more synonyms? thinking of elastic cloud + elasticsearch service being synonyms, for example also wondering if capitalization matters here |
|
@shainaraskas we run a lowercase filter in the analyzer so you are correct these need to be lowercased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase all terms
Good call. These are the ones that were already set up in the UI, but we can always use more as we go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are some other acronyms for you. I probably have some blind spots but hopefully this is a good start
| - [ "kql", "kibana query language" ] | ||
| - [ "ccr", "cross-cluster replication", "cross cluster replication" ] | ||
| - [ "esaas", "elastic stack as a service" ] | ||
| - [ "knn", "k-nearest neighbors" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plural/unplural automatic?
| - [ "knn", "k-nearest neighbors" ] | |
| - [ "knn", "k-nearest neighbors", "k-nearest neighbor" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, lets rely on stemmers to do this (if we need it to).
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Adding
synonyms.ymlbefore the rest of the changeset for synonyms as code, so we can have tests running properly on the branch as files are acquired frommain.