Skip to content

Conversation

@cotti
Copy link
Contributor

@cotti cotti commented Oct 22, 2025

Adding synonyms.yml before the rest of the changeset for synonyms as code, so we can have tests running properly on the branch as files are acquired from main .

@cotti cotti self-assigned this Oct 22, 2025
@cotti cotti added the ci label Oct 22, 2025
@cotti cotti requested review from a team as code owners October 22, 2025 13:20
@cotti cotti requested a review from Mpdreamz October 22, 2025 13:20
@shainaraskas
Copy link
Contributor

do you want more synonyms? thinking of elastic cloud + elasticsearch service being synonyms, for example

also wondering if capitalization matters here

@Mpdreamz
Copy link
Member

@shainaraskas we run a lowercase filter in the analyzer so you are correct these need to be lowercased

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase all terms

@cotti
Copy link
Contributor Author

cotti commented Oct 22, 2025

do you want more synonyms? thinking of elastic cloud + elasticsearch service being synonyms, for example

also wondering if capitalization matters here

Good call. These are the ones that were already set up in the UI, but we can always use more as we go.

@cotti cotti requested a review from Mpdreamz October 22, 2025 13:49
@cotti cotti enabled auto-merge (squash) October 22, 2025 14:13
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are some other acronyms for you. I probably have some blind spots but hopefully this is a good start

- [ "kql", "kibana query language" ]
- [ "ccr", "cross-cluster replication", "cross cluster replication" ]
- [ "esaas", "elastic stack as a service" ]
- [ "knn", "k-nearest neighbors" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plural/unplural automatic?

Suggested change
- [ "knn", "k-nearest neighbors" ]
- [ "knn", "k-nearest neighbors", "k-nearest neighbor" ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lets rely on stemmers to do this (if we need it to).

cotti and others added 5 commits October 22, 2025 11:24
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
@cotti cotti merged commit 5b75f72 into main Oct 22, 2025
22 checks passed
@cotti cotti deleted the feature/synonyms_file branch October 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants