Skip to content

Use EDOT sdk #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use EDOT sdk #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13adec8
Use EDOT sdk
reakaleek Nov 14, 2025
a856839
Merge branch 'main' into feature/use-edot-sdk
reakaleek Nov 14, 2025
4f2990e
Merge branch 'main' into feature/use-edot-sdk
Mpdreamz Nov 17, 2025
5d6d038
Merge branch 'main' into feature/use-edot-sdk
Mpdreamz Nov 17, 2025
7624937
Merge branch 'main' into feature/use-edot-sdk
reakaleek Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Elastic.Documentation.ServiceDefaults/Elastic.Documentation.ServiceDefaults.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App"/>
<PackageReference Include="Elastic.OpenTelemetry" />

<PackageReference Include="Microsoft.Extensions.Http.Resilience"/>
<PackageReference Include="Microsoft.Extensions.ServiceDiscovery"/>
Expand Down
21 changes: 11 additions & 10 deletions src/Elastic.Documentation.ServiceDefaults/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
logging.IncludeScopes = true;
});

_ = builder.Services.AddOpenTelemetry()
_ = builder.Services.AddElasticOpenTelemetry()
.WithMetrics(metrics =>
{
_ = metrics.AddAspNetCoreInstrumentation()
Expand Down Expand Up @@ -79,17 +79,18 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
{
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);

if (useOtlpExporter)
if (!useOtlpExporter)
return builder;

// Configure delta temporality for Elasticsearch compatibility
// See: https://www.elastic.co/docs/reference/opentelemetry/compatibility/limitations#histograms-in-delta-temporality-only
_ = builder.Services.Configure<MetricReaderOptions>(options =>
{
// Configure delta temporality for Elasticsearch compatibility
// See: https://www.elastic.co/docs/reference/opentelemetry/compatibility/limitations#histograms-in-delta-temporality-only
_ = builder.Services.Configure<MetricReaderOptions>(options =>
{
options.TemporalityPreference = MetricReaderTemporalityPreference.Delta;
});
options.TemporalityPreference = MetricReaderTemporalityPreference.Delta;
});

_ = builder.Services.AddOpenTelemetry().UseOtlpExporter();
Copy link
Contributor

@cotti cotti Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a new OTLP Exporter, breaking integration testing (and I'd assume live).

The reason it creates a new one is that an implicit default ElasticOpenTelemetryOptions has its SkipOtlpExporter set to false. Also, this starts a new OpenTelemetry service which is already defined in the beginning of ConfigureOpenTelemetry, is this wanted?


_ = builder.Services.AddOpenTelemetry().UseOtlpExporter();
}

// Uncomment the following lines to enable the Azure Monitor exporter (requires the Azure.Monitor.OpenTelemetry.AspNetCore package)
//if (!string.IsNullOrEmpty(builder.Configuration["APPLICATIONINSIGHTS_CONNECTION_STRING"]))
Expand Down
Loading