Isolate /search to /navigation-search and simplify our webcomponents #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move shared search infrastructure from Search/ to NavigationSearch/: - navigationSearch.store.ts (renamed from search.store.ts) - useNavigationSearchQuery.ts (uses /navigation-search endpoint) - useNavigationSearchCooldown.ts - useNavigationSearchRateLimitHandler.ts - Remove Search component and modal infrastructure: - Delete Search/ folder (Search.tsx, SearchResults/, etc.) - Delete SearchOrAskAiModal.tsx, modal.store.ts, modalmodes.ts - Delete useCooldown.ts (only used by modal) - Simplify SearchOrAskAiButton to only render NavigationSearch - Update AskAi components to be standalone (remove modal dependencies) - Update cooldown.store.ts to use local CooldownDomain type - Update tests and documentation (TESTING.md) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Mpdreamz
changed the title
reakaleek
reviewed
Jan 9, 2026
reakaleek
reviewed
Jan 9, 2026
src/Elastic.Documentation.Site/Assets/web-components/NavigationSearch/NavigationSearch.tsx
Show resolved
Hide resolved
reakaleek
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separates NavigationSearch and AskAi into independent web components to prepare for adding a real full-text search feature later.
The existing
/searchendpoint was an autocomplete for navigating to pages, not actual search. Renaming it to/navigation-searchclarifies its purpose and reserves/searchfor future full-text search functionality.Splitting the components also improves code organization - NavigationSearch and AskAi have different responsibilities and lifecycles, so coupling them together added unnecessary complexity.
Changes
/searchto/navigation-search<search-or-ask-ai>into two independent web components:<navigation-search>- autocomplete for page navigation<ask-ai>- AI assistant modal (Cmd+;)web-components/shared/Test plan