Skip to content

Conversation

@reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 29, 2025

Changes

Without a checkout action, the tj-actions/changes-files action will use the GitHub API to to determine the diff.
This way we can avoid checking out the forked PR and minimize the risk of using pull_request_target together
with actions/checkout.

Refs:

@reakaleek
Copy link
Member Author

cc @donoghuc

Thank you for your feedback. I was able to verify it on a test repo. It works 🚀

@reakaleek reakaleek requested a review from a team January 29, 2025 20:26
@reakaleek reakaleek self-assigned this Jan 29, 2025
@reakaleek reakaleek added the automation packaging, ci/cd. label Jan 29, 2025
@reakaleek reakaleek marked this pull request as ready for review January 29, 2025 20:26
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Avoiding code checkouts is a huge win for this usecase 🚀

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@reakaleek reakaleek merged commit 34e8b38 into main Jan 29, 2025
5 of 6 checks passed
@reakaleek reakaleek deleted the reakaleek-patch-1 branch January 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation packaging, ci/cd.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants