-
Notifications
You must be signed in to change notification settings - Fork 32
Add docs-builder mv command
#376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return true; | ||
| } | ||
|
|
||
| private async Task ProcessMarkdownFile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping that we could leverage markdig here.
E.g we parse the document AST and include a linkrewriter parser (or make it part of our existing DiagnosticLinksParser. To mutate the links.
Then we can write the AST back out again as markdown.
markdig supports roundtipping like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes totally sense.
Given the time and the need for it already today/tomorrow, do you think we can leave it this way for now and refactor it in a follow-up using Markdig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%! progress over perfection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes
Add
mvcommand to docs-builder CLI.Results
docs-builder mv ./docs/migration/ia.md ./docs/new-folder/ia.mddocs-builder mv --helpdocs-builder mv ./docs/migration/ia.md ./docs/new-folder/ia.md && git statusLimitations
docset.ymlandtoc.ymlfiles are not updated. However, you will get an error while building.