Skip to content

Fix root links #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Fix root links #382

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8355ef2
Fix root links
reakaleek Jan 30, 2025
796d754
Fix
reakaleek Jan 30, 2025
bfa6df3
Update src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlinePa…
reakaleek Jan 30, 2025
bd3497a
Update src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlinePa…
reakaleek Jan 30, 2025
28dd5d7
Merge branch 'main' into reakaleek-patch-1
reakaleek Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
if (url.EndsWith(".md"))
link.Url = Path.ChangeExtension(url, ".html");
// rooted links might need the configured path prefix to properly link
var prefix = processor.GetBuildContext().UrlPathPrefix;
var prefix = processor.GetBuildContext().UrlPathPrefix.TrimEnd('/');

Check failure on line 152 in src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.

Check failure on line 152 in src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.
if (url.StartsWith("/") && !string.IsNullOrWhiteSpace(prefix))
link.Url = $"{prefix}/{link.Url}";

Expand Down
Loading