Skip to content

Add matrix to pr workflow #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 17, 2025
Merged

Add matrix to pr workflow #425

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1722712
Add matrix
reakaleek Feb 5, 2025
5e75a19
Merge branch 'main' into feature/run-test-on-windows
Mpdreamz Feb 12, 2025
a09e2df
Split windows out of matrix and set shell explicitly
Mpdreamz Feb 12, 2025
09d8505
skip compile of build in release mode
Mpdreamz Feb 12, 2025
bb9dbcd
Merge branch 'main' into feature/run-test-on-windows
Mpdreamz Feb 26, 2025
f06b24d
Merge branch 'main' into feature/run-test-on-windows
reakaleek Mar 5, 2025
0e72b37
Merge branch 'main' into feature/run-test-on-windows
Mpdreamz Mar 14, 2025
61d7e59
Refactor
reakaleek Mar 14, 2025
894bc97
Merge branch 'main' into feature/run-test-on-windows
reakaleek Mar 14, 2025
43bc9c1
Fix Elastic.Markdown.Tests on Windows
cotti Mar 14, 2025
28c742a
Undo NavigationTests as they were working as intended.
cotti Mar 14, 2025
b92cfe4
Add prerelease step for Windows to configure line feed behavior.
cotti Mar 14, 2025
6042a10
Configure before checkout
cotti Mar 14, 2025
241e4bd
Remove eol directive from Git Configuration
cotti Mar 14, 2025
41d1a91
Remove PR as it breaks linting rules. Changing approach to individual…
cotti Mar 14, 2025
167e817
Handle more tests.
cotti Mar 14, 2025
a35adb9
Fix path inference on Windows for link references and MarkdownFile Ur…
cotti Mar 15, 2025
86ead9c
Fix MarkdownResultsAssertions on Windows
cotti Mar 15, 2025
2c1decc
Merge remote-tracking branch 'origin/main' into feature/run-test-on-w…
cotti Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ env:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, macos-latest ]
steps:
- uses: actions/checkout@v4

Expand All @@ -37,8 +41,30 @@ jobs:
run: ./build.sh publishbinaries

- uses: actions/upload-artifact@v4
Copy link
Member

@Mpdreamz Mpdreamz Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what we were using this for?

Copy link
Member Author

@reakaleek reakaleek Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was there in the initial implementation of the preview build, where we would download the built binary.

if: matrix.os == 'ubuntu-latest'
with:
name: docs-builder-binary
path: .artifacts/publish/docs-builder/release/docs-builder
if-no-files-found: error
retention-days: 1

build-windows:
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
steps:
- uses: actions/checkout@v4

- name: Bootstrap Action Workspace
id: bootstrap
uses: ./.github/actions/bootstrap

- name: Test
shell: cmd
run: build.bat test

- name: Publish AOT
shell: cmd
run: build.bat publishbinaries
1 change: 0 additions & 1 deletion docs-builder.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ Global
{10857974-6CF1-42B5-B793-AAA988BD7348}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{10857974-6CF1-42B5-B793-AAA988BD7348}.Debug|Any CPU.Build.0 = Debug|Any CPU
{10857974-6CF1-42B5-B793-AAA988BD7348}.Release|Any CPU.ActiveCfg = Release|Any CPU
{10857974-6CF1-42B5-B793-AAA988BD7348}.Release|Any CPU.Build.0 = Release|Any CPU
{28350800-B44B-479B-86E2-1D39E321C0B4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{28350800-B44B-479B-86E2-1D39E321C0B4}.Debug|Any CPU.Build.0 = Debug|Any CPU
{28350800-B44B-479B-86E2-1D39E321C0B4}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down
Loading