Fix pages navigation #528
Merged
Fix pages navigation #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mpdreamz maybe we can try something like https://github.com/Cysharp/Ulid, which seems to be faster in generating ids. WDYT? |
Mpdreamz
approved these changes
Feb 18, 2025
|
I don't think we generate UUID's at a rate which will require ULID, I'm also eager to start caching the whole navigation generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a chance that navigation items have the same slug. Since the slug is used to identify the input checkbox, the wrong navigation group gets opened/closed.
Changes
pointer-events-noneto avoid opening the group. (The group is visually opened twice, before the page is loaded and after the page is loaded)