Skip to content

Fix img src url #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 18, 2025
Merged

Fix img src url #532

merged 7 commits into from
Feb 18, 2025

Conversation

@reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek self-assigned this Feb 18, 2025
@reakaleek reakaleek requested a review from a team February 18, 2025 14:05
@reakaleek reakaleek added the fix label Feb 18, 2025
@reakaleek reakaleek marked this pull request as ready for review February 18, 2025 14:07
Mpdreamz
Mpdreamz reviewed Feb 18, 2025
View reviewed changes
Mpdreamz
Mpdreamz requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string replace on directory leaves me a bit nervous.

mind also adding a few comments with examples of the paths in the code?

@reakaleek
Copy link
Member Author

mind also adding a few comments with examples of the paths in the code?

Can you elaborate on this?

@Mpdreamz
Copy link
Member

mind also adding a few comments with examples of the paths in the code?

Can you elaborate on this?

e.g an example of the values of:

  • block.Build.ConfigurationPath.DirectoryName
  • block.CurrentFile.DirectoryName

And what the resulting Path.GetRelative() would return. Makes it a bit easier to read later again.

@reakaleek
Copy link
Member Author

mind also adding a few comments with examples of the paths in the code?

Can you elaborate on this?

e.g an example of the values of:

  • block.Build.ConfigurationPath.DirectoryName
  • block.CurrentFile.DirectoryName

And what the resulting Path.GetRelative() would return. Makes it a bit easier to read later again.

Got it. 6df6676

@reakaleek reakaleek enabled auto-merge (squash) February 18, 2025 14:39
@reakaleek reakaleek merged commit 4d1df99 into main Feb 18, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/fix-img-url branch February 18, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reakaleek @Mpdreamz